Sync eng/common directory with azure-sdk-tools for PR 15500#46772
Open
Sync eng/common directory with azure-sdk-tools for PR 15500#46772
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs the eng/common test-proxy pipeline templates with the corresponding updates from azure-sdk-tools PR 15500 by making the proxy bind URL configurable and consistently using it when starting and probing the proxy.
Changes:
- Added a new
proxyUrlparameter (defaulting tohttp://localhost:5000) to the test-proxy templates. - Updated proxy startup commands (Windows + Linux/macOS) to pass
--urlsso the proxy binds to the configured URL. - Updated the IsAlive probe to target the configured
proxyUrlinstead of a hard-coded localhost URL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/common/testproxy/test-proxy-tool.yml | Adds proxyUrl parameter; uses it for proxy startup --urls and for the IsAlive probe. |
| eng/common/testproxy/test-proxy-standalone-tool.yml | Same as above for the standalone proxy tool template ($(PROXY_EXE)). |
| Invoke-WebRequest -Uri "http://localhost:5000/Admin/IsAlive" | Out-Null | ||
| Write-Host "Invoke-WebRequest -Uri `"${{ parameters.proxyUrl }}/Admin/IsAlive`" | Out-Null" | ||
| Invoke-WebRequest -Uri "${{ parameters.proxyUrl }}/Admin/IsAlive" | Out-Null | ||
| Write-Host "Successfully connected to the test proxy on port 5000." |
| Invoke-WebRequest -Uri "http://localhost:5000/Admin/IsAlive" | Out-Null | ||
| Write-Host "Invoke-WebRequest -Uri `"${{ parameters.proxyUrl }}/Admin/IsAlive`" | Out-Null" | ||
| Invoke-WebRequest -Uri "${{ parameters.proxyUrl }}/Admin/IsAlive" | Out-Null | ||
| Write-Host "Successfully connected to the test proxy on port 5000." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#15500 See eng/common workflow